Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A rotation function #14

Open
astro-ray opened this issue Dec 12, 2022 · 2 comments
Open

A rotation function #14

astro-ray opened this issue Dec 12, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@astro-ray
Copy link
Contributor

A function that rotates the curve by a certain $\theta$ angle. The implementation is easy, it will take $\theta$, and the curve as input, and method is just like TransformedCurve, but the matrix used will be:

$$A(\theta)=\begin{pmatrix} \cos\theta & -\sin\theta\\ \sin\theta & \cos\theta \end{pmatrix}$$

@dylannalex dylannalex added the enhancement New feature or request label Dec 12, 2022
@dylannalex
Copy link
Owner

Hey @ritamsaha00, thanks for opening an issue!

Originally (on version 0.1.1 and below), curvipy provided a RotatedCurve class. On curvipy 1.0.0, when I reorganized the whole structure of curvipy, I decided to remove this class because it's not part of the core of curvipy, since it can easily be defined using the 'curvipy.TransformedCurve' class.

Anyways, I think it might be a good idea to create a subpackage where we can develop more specific curves and vectors, such as the rotation function you proposed. Let me know what you think about this, and tell me if you came up with an idea of what to name this subpackage and its modules!

@astro-ray
Copy link
Contributor Author

astro-ray commented Dec 20, 2022

Hello @dylannalex , I have been thinking about the name of a subpackage and what could go in it. I think there can be a sub-package called specialOperation where we could have modules like rotation and Fourier etc. ( I have only thought about these two modules for the time being ). What do you think about this approach?

@dylannalex dylannalex added the good first issue Good for newcomers label Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants