Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: new version of node-letsencrypt #5

Closed
coolaj86 opened this issue Feb 12, 2016 · 6 comments
Closed

FYI: new version of node-letsencrypt #5

coolaj86 opened this issue Feb 12, 2016 · 6 comments

Comments

@coolaj86
Copy link

Hey Dylan, I just wanted to make you aware that I published a new version of letsencrypt (v1.0.8). It fixes a bug where the registerAsync would return before registration was complete and a bug in the pyconf parser/stringifier.

I don't think anything should have broken, but please let me know if you have any issues with it.

@coolaj86 coolaj86 changed the title FYI: new version of letsencrypt FYI: new version of node-letsencrypt Feb 12, 2016
@DylanPiercey
Copy link
Owner

@coolaj86 Thanks for letting me know!

I'll run some tests and make an update.

@DylanPiercey
Copy link
Owner

@coolaj86 Looks like current version is 1.4.2 which I updated to yesterday, is there another release that I am missing?

Great work on node-letsencrypt by the way.

@DylanPiercey
Copy link
Owner

Closing this for now, @coolaj86 let me know if I've missed something.

@coolaj86
Copy link
Author

I had my versions confused. I was referencing letsencrypt-express (similar to what you have here, but with a callback for initial approval). That said, I did publish a new version of letsencrypt (v1.4.3) just now with a few bugfixes, including some from letiny-core.

@DylanPiercey
Copy link
Owner

Cool thanks, i'll take a look later today.

@DylanPiercey
Copy link
Owner

Looks good to me. Good work @coolaj86 and @martinheidegger. Updated deps in db07d76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants