New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move rust code into parent dir #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwkeyboard
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this!
nilslice
added a commit
that referenced
this pull request
Jun 26, 2023
* feat: nest function call events, start json otel adapter * fix: drop version down to 0.0 temporarily * feat: add otel stdout adapter and demo bin * chore: add test wasm * chore: reverse returns of collector stack methods to use comma-ok pattern * chore: cleanup resolved comment/todo * fix: rename scopeSpan to scopeSpans as per spec
nilslice
added a commit
that referenced
this pull request
Jul 27, 2023
feat: separate adapter and collector, add demangling feat: add datadog adapter, re-export from sdk feat: implement support for allocation tracking chore: centralize util id functions fix: update import paths chore: remove span collector id fix: add modsurfer-demangle to the repo fix: correct trace endpoint, address pr feedback fix: duration correction chore: remove name truncation fix: use put for datadog request feat: Produce bundles for Deno & Node feat: add web build feat: create separate npm packages for datadog and stdout adapters feat: create separate npm packages for datadog and stdout adapters fix: support allocation tracing attached to functions (#4) * fix: support allocation tracing attached to functions * chore: include additional wasm module for testing * test: update tests to use other wasm * fix: update package.json to use new tests chore: gen build files chore: commit build files fix: node test chore: create packages directory chore: use package name as directory name feat: parse custom name section without wasm-parser, create universal distributables chore: package cleanup chore: remove dist chore: relocate js sdk to merge Co-Authored-By: Rob Wong <rob@dylibso.com>
nilslice
added a commit
that referenced
this pull request
Jul 27, 2023
feat: separate adapter and collector, add demangling feat: add datadog adapter, re-export from sdk feat: implement support for allocation tracking chore: centralize util id functions fix: update import paths chore: remove span collector id fix: add modsurfer-demangle to the repo fix: correct trace endpoint, address pr feedback fix: duration correction chore: remove name truncation fix: use put for datadog request feat: Produce bundles for Deno & Node feat: add web build feat: create separate npm packages for datadog and stdout adapters feat: create separate npm packages for datadog and stdout adapters fix: support allocation tracing attached to functions (#4) * fix: support allocation tracing attached to functions * chore: include additional wasm module for testing * test: update tests to use other wasm * fix: update package.json to use new tests chore: gen build files chore: commit build files fix: node test chore: create packages directory chore: use package name as directory name feat: parse custom name section without wasm-parser, create universal distributables chore: package cleanup chore: remove dist chore: relocate js sdk to merge Co-Authored-By: Rob Wong <rob@dylibso.com>
nilslice
added a commit
that referenced
this pull request
Jul 28, 2023
feat: separate adapter and collector, add demangling feat: add datadog adapter, re-export from sdk feat: implement support for allocation tracking chore: centralize util id functions fix: update import paths chore: remove span collector id fix: add modsurfer-demangle to the repo fix: correct trace endpoint, address pr feedback fix: duration correction chore: remove name truncation fix: use put for datadog request feat: Produce bundles for Deno & Node feat: add web build feat: create separate npm packages for datadog and stdout adapters feat: create separate npm packages for datadog and stdout adapters fix: support allocation tracing attached to functions (#4) * fix: support allocation tracing attached to functions * chore: include additional wasm module for testing * test: update tests to use other wasm * fix: update package.json to use new tests chore: gen build files chore: commit build files fix: node test chore: create packages directory chore: use package name as directory name feat: parse custom name section without wasm-parser, create universal distributables chore: package cleanup chore: remove dist chore: relocate js sdk to merge Co-Authored-By: Rob Wong <rob@dylibso.com>
nilslice
added a commit
that referenced
this pull request
Jul 28, 2023
feat: separate adapter and collector, add demangling feat: add datadog adapter, re-export from sdk feat: implement support for allocation tracking chore: centralize util id functions fix: update import paths chore: remove span collector id fix: add modsurfer-demangle to the repo fix: correct trace endpoint, address pr feedback fix: duration correction chore: remove name truncation fix: use put for datadog request feat: Produce bundles for Deno & Node feat: add web build feat: create separate npm packages for datadog and stdout adapters feat: create separate npm packages for datadog and stdout adapters fix: support allocation tracing attached to functions (#4) * fix: support allocation tracing attached to functions * chore: include additional wasm module for testing * test: update tests to use other wasm * fix: update package.json to use new tests chore: gen build files chore: commit build files fix: node test chore: create packages directory chore: use package name as directory name feat: parse custom name section without wasm-parser, create universal distributables chore: package cleanup chore: remove dist chore: relocate js sdk to merge Co-Authored-By: Rob Wong <rob@dylibso.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for additional language/runtime support, moving the existing SDK code into a language specific directory will make it easier to minimize any impact to dependent users.
To check this, run:
make test
cargo build
Adding a Cargo
workspace
in the root here should keep all of these working just fine.