Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals with button triggers break styling under a button group #1

Open
dylnslck opened this issue Jul 14, 2016 · 0 comments
Open

Modals with button triggers break styling under a button group #1

dylnslck opened this issue Jul 14, 2016 · 0 comments

Comments

@dylnslck
Copy link
Owner

For example:

<ButtonGroup>
  <Modal>
    <Trigger>
      <Button color="primary">Basic modal</Button>
    </Trigger>
    <Content>
      <BasicModal title="Basic Modal">
        <p>this is a basic modal</p>
        <Tooltip text="A tooltip man!" attachment="bottom center">
          <Trigger>
            <Button>Tooltip</Button>
          </Trigger>
          <Content>
            <div>i am a tooltip</div>
          </Content>
        </Tooltip>
      </BasicModal>
    </Content>
  </Modal>
  <Modal>
    <Trigger>
      <Button color="primary">Confirm modal</Button>
    </Trigger>
    <Content>
      <ConfirmModal
        title="Are you sure you want to do this?"
        onConfirm={onConfirm}
      />
    </Content>
  </Modal>
</ButtonGroup>

The button borders are breaking because Modal inserts a span tag around button elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant