Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] .coveragerc is ignored on CI #990

Closed
pedro-psb opened this issue Aug 26, 2023 · 1 comment
Closed

[CI] .coveragerc is ignored on CI #990

pedro-psb opened this issue Aug 26, 2023 · 1 comment
Labels
CI Continous Integration Issues
Milestone

Comments

@pedro-psb
Copy link
Member

After Dynconf began using the Codecov GitHub app this week, the coverage report is ignoring .coveragerc passing rules (fail under 95%) and is often failing with very small coverage changes.

This solution looks simple: use codecov.yml file. We just need to ensure a clean integration with both local and CI setups.

@pedro-psb pedro-psb added bug CI Continous Integration Issues and removed bug labels Aug 26, 2023
@pedro-psb pedro-psb added this to the 3.2.3 milestone Sep 4, 2023
@rochacbruno rochacbruno modified the milestones: 3.2.3, 3.2.4 Sep 11, 2023
@pedro-psb
Copy link
Member Author

For now, this has been set up correctly via GH Apps and .coveragerc should be kept for local reports.

It is not very good that we have two sources of coverage definitions (Apps and the file), but that's a more general issue and should be addressed when migrating to pyproject.toml #929, so I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continous Integration Issues
Projects
None yet
Development

No branches or pull requests

2 participants