Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no version ranges for dependencies #39

Closed
ulf1 opened this issue Oct 27, 2023 · 4 comments
Closed

no version ranges for dependencies #39

ulf1 opened this issue Oct 27, 2023 · 4 comments

Comments

@ulf1
Copy link

ulf1 commented Oct 27, 2023

derivative

@ulf1
Copy link
Author

ulf1 commented Oct 27, 2023

for example numpy>=1,<2 instead of just numpy

Why? breaking changes can happen. a maintainer should ensure that any version of the maintained package works (e.g. when installing an old version pykoopman in 5 years to reproduce a study, or simply deploy an old docker container)

@ulf1
Copy link
Author

ulf1 commented Oct 27, 2023

note tthat version range applies to setup.py as well

@Dionysus7777777
Copy link

the version of python is adivced to be 3.10 and you ‘d better do not use pip to down the pykoopman,i suggest that you download it from github

@pswpswpsw
Copy link
Collaborator

you are very correct about this.. In fact I observed some of those issues and complained about it.. I have corrected it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants