Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Defect] In the case of cost_constrained_qr, the algorithm should error out if the number of sensors is larger than the number of samples #14

Closed
Jimmy-INL opened this issue Jun 25, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Jimmy-INL
Copy link
Contributor

In the cost_constrained_qr algorithms, there must be an assertion or an IOError if the number of sensors is greater than the number of samples, this will cause the current implementation after the sensors exceed the number of samples (i.e., after 300 in the notebook example) will start ignoring the constrained area. Of course, this is a rare occasion, primarily since the whole idea is based on sparsity, but some users might have limited samples and might still try this.

To reproduce this issue, go to the ./examples/cost_constrained_qr.ipynb and change n_sensors to 350, you will see sensors start to be placed in the constrained areas.

@briandesilva briandesilva self-assigned this Jun 30, 2022
@briandesilva briandesilva added the bug Something isn't working label Jun 30, 2022
@briandesilva
Copy link
Member

Thanks for pointing this out! I'll implement a fix and update the package in the next few weeks.

@briandesilva
Copy link
Member

I've added a warning for this case and released it in v0.3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants