Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "template" tag from children of .slider-container and .slider-indicators making library compatible with AlpineJS #46

Open
Teods opened this issue Jul 8, 2022 · 0 comments

Comments

@Teods
Copy link

Teods commented Jul 8, 2022

Is your feature request related to a problem? Please describe.
I want the library to be compatible with AlpineJs and the Web HTML Element "template". AlpineJS use the "template" element for every actions, loop etc... and SwiffySlider take alld child element to display indicators and slide.
See AlpineJS Templating usage : https://alpinejs.dev/essentials/templating#looping-elements

Describe the solution you'd like
I already implemented the solution (PR in preparation) it simply consist in excluding the "template" from the children and let all other tags as is

PR #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant