Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up the plugin v1 conversion code #153

Open
radu-stefan-dt opened this issue Dec 29, 2023 · 2 comments
Open

Tidy up the plugin v1 conversion code #153

radu-stefan-dt opened this issue Dec 29, 2023 · 2 comments
Assignees
Labels
housekeeping Project setup, structure, style guides, conventions, etc. improvement Enhancement of existing functionality

Comments

@radu-stefan-dt
Copy link
Collaborator

Some organization and re-structuring would be good for our plugin v1 conversion code.

Main points to address:

  • schema conversion functions (both from JMX and Python) should be moved into src/utils folder
  • Consider opportunities for reducing duplication between JMX & Python conversions:
    • Either merging the flows with additional parameters
    • Or, given we plan to enhance python conversion, extract more of the flow into utility functions to be moved into src/utils
@radu-stefan-dt radu-stefan-dt added improvement Enhancement of existing functionality housekeeping Project setup, structure, style guides, conventions, etc. labels Dec 29, 2023
@dlopes7 dlopes7 self-assigned this Dec 29, 2023
@radu-stefan-dt
Copy link
Collaborator Author

@dlopes7 I'm trying to organise work based on releases.
Should I include this in upcoming release (1 month ish) or next one (2 months ish)?

@dlopes7
Copy link
Contributor

dlopes7 commented Jan 4, 2024

1 monthish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Project setup, structure, style guides, conventions, etc. improvement Enhancement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants