#133 CriticalTime Calculation implementation done. Tests added in API… #136
Conversation
| @@ -101,6 +101,34 @@ XmlExporter::exportLoadIncreaseResultsToStream(const vector<LoadIncreaseResult>& | |||
| formatter->endDocument(); | |||
| } | |||
|
|
|||
| void | |||
| XmlExporter::exportCriticalTimeResultsToFile(double criticalTime, const std::string& messageCriticalTimeError, std::string filePath) const { | |||
There was a problem hiding this comment.
const std::string& filePath
| /** | ||
| * @brief Export critical time calculation results into a file | ||
| * | ||
| * @param results aggregated results to export |
There was a problem hiding this comment.
doxygen is not correct (same below)
|
|
||
| void | ||
| CriticalTimeCalculation::setAccuracy(double accuracy) { | ||
| if (accuracy < 0 || accuracy > 1) |
There was a problem hiding this comment.
if (accuracy < 0 || accuracy > 1 || doubleIsZero(accuracy))
| } | ||
|
|
||
| void | ||
| CriticalTimeCalculation::setJobsFile(std::string jobsFile) { |
| dydId_ = dydId; | ||
| } | ||
|
|
||
| std::string |
| // First simulation case. | ||
| SetParametersAndLaunchSimulation(); | ||
| if (results_.getSuccess()) | ||
| tSup_ += std::round(((tSup_ - tInf) / 2) * multiplierRound) / multiplierRound; |
There was a problem hiding this comment.
I don't see any check that tInf < tSup
| } | ||
|
|
||
| void | ||
| CriticalTimeLauncher::updateIndexes(double& tPrevious, double& curAccuracy, const double& multiplierRound) { |
There was a problem hiding this comment.
Since this method is small and called only once in the code I would propose to remove it and put the code directly below
| if (!results_.getSuccess()) | ||
| tSup_ -= accuracy; | ||
|
|
||
| tSup_ = std::round(tSup_ * multiplierRound) / multiplierRound;; |
| // | ||
|
|
||
| /** | ||
| * @file DYNMarginCriticalimeLauncher.h |
|
|
||
| std::string simulationMC_SA_CS_CTC = "Set the simulation type to launch : MC (Margin calculation), SA (systematic analysis), CS (compute simulation)" | ||
| " or CTC (critical time calculation)"; | ||
| const char* allSimulationsType = simulationMC_SA_CS_CTC.c_str(); |
There was a problem hiding this comment.
useless, please use directly simulationMC_SA_CS_CTC.c_str() below
…, Common and Launcher
…onst...) + optimize the critical time algorithm following advices from Florentine
gautierbureau
force-pushed
the
133_CTC_Implementation
branch
from
53d22cd
to
a83abd7
Compare
|
I updated with a recent master and added some fix to make the branch work. To make the test case work with Dynawo temporary we need to add the following lines in |
|
From my understanding, only the first job of the fic_multiple is read. But it could be useful to compute the CCTs of all generators in one go (possibly using the "dydFile" entry). |
closes #133