Add a ParseAPI::Block constructor to allow external parsers to set correctly block end address #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect block end address
|
@hainest Ready to test. |
|
@mxz297 Could you also update the ParseAPI documentation? |
|
https://bottle.cs.wisc.edu/search?dyninst_branch=PR1011 Testing looks good. |
|
@hainest It is awkward that there is no mention of ParseAPI::Block constructors in the ParseAPI documentation... |
|
@hainest I pushed a commit that documents the block constructors. I did not recompile the PDF. Can you proof-read it and update the PDF file? |
|
LGTM. Since we're so close to a release, I'll wait to generate the PDFs until then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.