Merge and fix Windows rewriter

[jdetter]

From Bill:

The fork at https://github.com/ea/dyninst contains significant steps towards completion of the Windows binary rewriter. It is missing some key elements, however; its handling of relocation fixup is IIRC incomplete, and it produces binaries that do not execute cleanly.

This issue should be closed and replaced with specific bugs once that fork is merged back to a dyninst/dyninst topic branch and we have evaluated where things stand after another year+ of work on Windows parsing and relocation handling on the analysis side of things.

[richinseattle]

Can someone give us an update on what the status is of merging this work into current trunk? It was stated on the Dyninst release notes that Windows support was targeted for 9.3.1 but I don't think that happened. The above fork was done as part of work on my team at Cisco Talos and we would like to see forward progress with our efforts. I know there have been additional patches submitted by Van Hauser and Patrick Stach to fix some of the register borrowing that I believe was part of the reason our emitted binaries were broken since MSVC makes heavy use of rsi and rdi which were effected.

[richinseattle]

Issue closed without comment or status updates after we sent significant patches your way?

[mxz297]

I am really sorry. No human resource has been devoted to the development of the Windows support in the past a few years.

[richinseattle]

Is that a reason to close this bug? Earlier comments and more recent activity indicated this would eventually be taken up again since there was supposed to be work on the Windows DBI functionality though I haven’t seen much discussion or documentation of that and there hasn’t been a windows release in years.

[mxz297]

As far as I know, there is no Windows development plan in the near future unless there are going to be new developers. Unfortunately as I mentioned, there hasn't been a windows release in years exactly because no human resource has been spent on Windows.

I am fine to leave this issue open if we do have resource for Windows development.

Thanks for your feedback!