Warnings not being properly disabled under Visual Studio

[pefoley2]

The /wd flags in warnings.cmake are being outputted to the .vcxproj files, but not passed down to the cl.exe command line, causing a flood of warning spam.

[wrwilliams]

@pefoley2 Do you have any idea how to ensure that these flags get passed to the build tool appropriately in CMake?

[pefoley2]

It looks like the actual issue was an incorrect pragma in InstructionAPI.h causing warning 4251 to be unconditionally enabled
See https://github.com/pefoley2/dyninst/commit/9ea3f33c682c4ed6ad8ceb93b2ef258c5fc4e880

[wrwilliams]

Very nice, and a good catch. That was really dumb of past-me.

[pefoley2]

It took a while to figure out why the flag wasn't applying, but it was obvious once I figured out what was happening :)

[wrwilliams]

Verified that this is fixed on master; closing.