Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT entries misparsed on ARM #32

Closed
wrwilliams opened this issue May 9, 2016 · 2 comments
Closed

PLT entries misparsed on ARM #32

wrwilliams opened this issue May 9, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@wrwilliams
Copy link
Member

Our PLT parsing mechanism on ARM is not doing the right thing, and is quite brittle. We should follow what the linker does in its generation of PLT stubs rather than relying on magic numbers/sizes/instruction sequences wherever possible.

@wrwilliams wrwilliams added this to the 9.2 Release milestone May 9, 2016
@mxz297
Copy link
Member

mxz297 commented May 10, 2016

Fix this issue by skipping the first two plt entry size on ARM #37.

This is not the ideal fix, but our alternative does not work. We tried to look up symbols in the .dynsym section to locate the address of a PLT stub, but this method would fail as there could be a PLT stub and a function in .text and these two have the same name; the symbol in .dynsym points to the function entry in the .text section. Therefore, we cannot determine the location of PLT stubs by looking at .dynsym

@mxz297
Copy link
Member

mxz297 commented May 27, 2016

#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants