New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebx should be callee-saved #399

Closed

ghost opened this issue Aug 10, 2017 · 1 comment

Milestone

ghost commented Aug 10, 2017 •

edited by ghost

Shouldn't ebx on x86_32 be callee-saved? It seems to be incorrectly added to callWritten due to the assignment at this line: https://github.com/dyninst/dyninst/blob/master/dataflowAPI/src/ABI.C#L222. This results in inconsistent slicing behavior when ebx is involved.

We discussed this some while ago on the mailing list. It seems the fix never made it to master.

melsabagh mentioned this issue

Update ABI.C: remove ebx from callWritten_ #425

Closed

wrwilliams added this to the Release 10.0.0 milestone

Member

mxz297 commented Oct 25, 2018

Closed by #425

mxz297 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment