Remove undefined behavior from Symtab::Type #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling a member function of a base class before the base class's constructor has completed is undefined behavior.
|
Looks good to me. |
|
@hainest Sorry for the delay. Looks good to me. |
|
I've manually verified that this PR does not introduce any regressions (the regressions in the dashboard are carryover from other breakages). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling a member function of a base class before the base class's constructor has completed is undefined behavior.
I tried not to change
Type's API, but the member needed to be extracted in order to be handled during base class construction.@mxz297 @blue42u Could you double-check that I didn't change the semantics?