Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiler-specific search directories in getResolvedLibraryPath #732

Merged
merged 2 commits into from Apr 21, 2020
Merged

Add compiler-specific search directories in getResolvedLibraryPath #732

merged 2 commits into from Apr 21, 2020

Conversation

hainest
Copy link
Contributor

@hainest hainest commented Mar 30, 2020

This extends the functionality of #731 to automatically find and search compiler-specific library paths when using gcc and clang.

@hainest hainest self-assigned this Mar 30, 2020
@hainest
Copy link
Contributor Author

hainest commented Mar 30, 2020

@mxz297 @sashanicolas Do you know if there are already some macros to do macro stringification somewhere in the codebase?

@hainest
Copy link
Contributor Author

hainest commented Mar 30, 2020

https://bottle.cs.wisc.edu/search?dyninst_branch=PR732

This has fixed the static rewriter issues on coriander without user intervention.

@mxz297
Copy link
Member

mxz297 commented Mar 30, 2020

@hainest I am not aware of such code.

@hainest
Copy link
Contributor Author

hainest commented Apr 19, 2020

https://bottle.cs.wisc.edu/search?dyninst_branch=PR732&since_date=2020-04-15

This is now passing on all platforms (the regressions shown are unrelated to this PR). Importantly, test_reloc is now passing everywhere (modulo some intermittent failures and the unfixable failures on RHEL7).

@mxz297 @sashanicolas From these test results, it looks like unconditionally adding libgcc.a is not causing any issues. Do either of you have other platforms you want to test this on before accepting it?

dyninstAPI/CMakeLists.txt Outdated Show resolved Hide resolved
@hainest hainest merged commit 194dda7 into dyninst:master Apr 21, 2020
@hainest hainest deleted the compiler_search_dirs branch May 30, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants