Libxul fixes #755
Merged
Libxul fixes #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define ROSE_ASSERT so that a signal is thrown for instruction semantic errors instead of doing an assertion abort.
2. Fix typo regarding to non-returning functions 3. The moving of edges for block split should be protected with a lock
…l table information.
|
@stanfordcox Does this fix the problems you were seeing? |
|
The 6 commits fix the libxul analysis error while doing bpatch.processAttach |
This was referenced May 28, 2020
Merged
|
https://bottle.cs.wisc.edu/search?dyninst_branch=PR755 Things are looking good. I want to re-run the test suite on quartz to make sure those errors aren't real regressions (I doubt they are; test_reloc has been a pain for a long time). @mxz297 Once I'm convinced it's testing well, can I merge? |
|
@hainest Yes, you can merge this PR when you feel good about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes necessary fixes for analyzing libxul.so from FireFox.
Fix #747