Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-breaking changes for 11.0 release #920

Merged
merged 9 commits into from Nov 20, 2020
Merged

API-breaking changes for 11.0 release #920

merged 9 commits into from Nov 20, 2020

Conversation

hainest
Copy link
Contributor

@hainest hainest commented Nov 17, 2020

No description provided.

This was originally part of #317.
This is an API-breaking change since AddressSpace is exported through
the BPatch interface.
dyninstAPI/src/codegen-power.C: Removed by 5274e3b in 2011.
dyninstAPI/src/codegen-aarch64.C: Removed by 0cbe684 in 2015.
dyninstAPI/src/codegen-x86.C: git can't figure out when this was removed.
This was deprecated by 7f20129 in 2010. Users should instead use either
BPatch_addressSpace::findFunctionByEntry or
BPatch_addressSpace::findFunctionsByAddr.
This was deprecated by 4d15de8 in 2008.
* Remove all code guarded by SERIALIZATION_DISABLED
* Remove code protected by cap_serialization
* Remove serialize-bin
* Remove serialization classes and their uses
* Simplify Symtab::getObject
    Because serialization doesn't exist, their is only one codepath here
    now.
This removes the possiblity of object reuse and its associated undefined
behavior. This was originally part of #317.
@hainest hainest added code cleanup Bring the code up to modern standards or remove deprecated features API-BREAKER This change breaks the public API labels Nov 17, 2020
@hainest hainest added this to the Release 11.0 milestone Nov 17, 2020
@hainest hainest self-assigned this Nov 17, 2020
@hainest
Copy link
Contributor Author

hainest commented Nov 20, 2020

https://bottle.cs.wisc.edu/search?dyninst_branch=PR920

No new regressions.

@hainest hainest merged commit f4ee341 into master Nov 20, 2020
@hainest hainest deleted the api_breakages branch November 20, 2020 04:12
bbiiggppiigg pushed a commit to bbiiggppiigg/dyninst that referenced this pull request Dec 4, 2020
* Remove deprecated BPatch_snippet::getCost* (dyninst#832)
    These were deprecated by 52f3437 in 2010.

* Remove deprecated BPatch_process::enableDumpPatchedImage (dyninst#831)
    This was deprecated by 4d83371 in 2011.

* Remove AddressSpace::getAddressWidth from public API (dyninst#797)
    This was originally part of dyninst#317.

* Fix memory leak of AddressSpace::patcher_ (dyninst#795)
    This was originally part of dyninst#317.
    This is an API-breaking change since AddressSpace is exported through
    the BPatch interface.

* Remove deprecated insnCodeGen::generate (dyninst#836)
    dyninstAPI/src/codegen-power.C: Removed by 5274e3b in 2011.
    dyninstAPI/src/codegen-aarch64.C: Removed by 0cbe684 in 2015.
    dyninstAPI/src/codegen-x86.C: git can't figure out when this was removed.

* Remove BPatch_addressSpace::findFunctionByAddr (dyninst#837)
    This was deprecated by 7f20129 in 2010. Users should instead use either
    BPatch_addressSpace::findFunctionByEntry or
    BPatch_addressSpace::findFunctionsByAddr.

* Remove deprecated BPatch_regExpr (dyninst#838)
    This was deprecated by 4d15de8 in 2008.

* Remove serialization (dyninst#805)
    Remove all code guarded by SERIALIZATION_DISABLED
    Remove code protected by cap_serialization
    Remove serialize-bin
    Remove serialization classes and their uses
    Simplify Symtab::getObject
        Because serialization doesn't exist, their is only one codepath here now.

* Remove CFGFactor::destroy_all (dyninst#881)
    This removes the possiblity of object reuse and its associated undefined
    behavior. This was originally part of dyninst#317.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-BREAKER This change breaks the public API code cleanup Bring the code up to modern standards or remove deprecated features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant