Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unhandled enum values for Intel GPUs #955

Merged
merged 1 commit into from Feb 5, 2021
Merged

Fix unhandled enum values for Intel GPUs #955

merged 1 commit into from Feb 5, 2021

Conversation

Jokeren
Copy link
Contributor

@Jokeren Jokeren commented Jan 30, 2021 •
edited by hainest

Fixes #953

@Jokeren Jokeren mentioned this pull request Jan 30, 2021
Closed
@hainest
Copy link
Contributor

hainest commented Jan 30, 2021

Looks good. I'll run it through our usually testing battery, but I expect no troubles. Thanks for the quick fix, Keren!

@hainest
Copy link
Contributor

hainest commented Feb 2, 2021

@Jokeren Could you rebase this on the current HEAD?

@hainest hainest self-assigned this Feb 2, 2021
@hainest hainest added code cleanup Bring the code up to modern standards or remove deprecated features GPUs This issue is related to handling of GPU code labels Feb 2, 2021
@Jokeren
Copy link
Contributor Author

Jokeren commented Feb 2, 2021

@hainest Done

@hainest
Copy link
Contributor

hainest commented Feb 4, 2021

https://bottle.cs.wisc.edu/search?dyninst_branch=PR955

LGTM. @Jokeren @mxz297 Were you able to resolve the getPC question? Do we need to wait for that to be resolved before merging this?

@Jokeren
Copy link
Contributor Author

Jokeren commented Feb 4, 2021

It should be good to go. AFAIK, We don't actually rely on getPC for cuda and intel gpu instructions.

@hainest hainest changed the title Cleanup intel registers Fix unhandled enum values for Intel GPUs Feb 5, 2021
@hainest hainest merged commit 46d1cdd into dyninst:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hainest hainest

Labels
code cleanup Bring the code up to modern standards or remove deprecated features GPUs This issue is related to handling of GPU code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhandled enum values for Intel GPUs
2 participants
@Jokeren @hainest