Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shifts of negative values #976

Merged
merged 1 commit into from Feb 4, 2021
Merged

Fix shifts of negative values #976

merged 1 commit into from Feb 4, 2021

Conversation

hainest
Copy link
Contributor

@hainest hainest commented Feb 3, 2021

This is undefined behavior in C++.

@hainest
Fix shifts of negative values
9935f23 
This is undefined behavior in C++.
@hainest hainest added bug code cleanup Bring the code up to modern standards or remove deprecated features labels Feb 3, 2021
@hainest hainest added this to the Release 11.0 milestone Feb 3, 2021
@hainest hainest self-assigned this Feb 3, 2021
@hainest
Copy link
Contributor Author

hainest commented Feb 4, 2021

https://bottle.cs.wisc.edu/search?dyninst_branch=PR976

No new regressions.

@hainest hainest merged commit 38041d5 into dyninst:master Feb 4, 2021
@hainest hainest deleted the fix_shift_negative_value branch February 4, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hainest hainest

Labels
bug code cleanup Bring the code up to modern standards or remove deprecated features
Projects
None yet
Milestone
Release 11.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hainest