Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why did the kpatch-build script export the KPATCH-BUILD environment variable from the BUILD directory to the SOURCE directory? #1387

Closed
PshySimon opened this issue Apr 17, 2024 · 3 comments
Labels

Comments

@PshySimon
Copy link

I have a question about this commit submission, 89a871f

Previously, KPATCH_BUILD was the build directory, now it has become the source directory. Is this really okay? I tried to compile the OOT module and failed.I then realized there was an issue with this directory, and only after changing it to the BUILD directory did it succeed.

@joe-lawrence
Copy link
Contributor

It's been quite a while since this was changed, but from 4a7dab1:

I also tried to disambiguate `SRCDIR` in kpatch-build a bit. Now there are 3 variables:
- `KERNEL_SRCDIR` - contains path to kernel source directory
- `OOT_MODULE_SRCDIR` - contains path to out-of-tree module source directory
- `BUILDDIR` - can be set to either of the above and is used for patch-related actions

so I think BUILDDIR allows kpatch-build to run make from either the kernel tree or an OOT module tree.

What is the command line that you are using to build your kpatch for an OOT module. It's not as common as building for vmlinux/in-tree-modules so there may very well be a bug in the script.

Copy link

This issue has been open for 30 days with no activity and no assignee. It will be closed in 7 days unless a comment is added.

@github-actions github-actions bot added the stale label May 18, 2024
Copy link

This issue was closed because it was inactive for 7 days after being marked stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants