Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined property values should be ignored #26

Closed
Zolmeister opened this issue Aug 13, 2017 · 0 comments
Closed

undefined property values should be ignored #26

Zolmeister opened this issue Aug 13, 2017 · 0 comments
Assignees
@thysultan

Comments

@Zolmeister
Copy link

Zolmeister commented Aug 13, 2017 •
edited 

h('a', {href: undefined})
// got: <a href="undefined">
// expected: <a>

this is caused becuase of how setAttribute works

$a.setAttribute('href', undefined)
// <a href="undefined">

also null should probably be ignored as well
@thysultan thysultan self-assigned this Aug 24, 2017
@Zolmeister Zolmeister mentioned this issue Aug 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thysultan thysultan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zolmeister @thysultan