Fix wrapper class of datepicker container #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please create an issue relevant to this? |
|
Sure
…On Fri, May 25, 2018 at 10:07 PM, Roozbeh Hajizadeh < ***@***.***> wrote:
Can you please create a issue relevant to this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhGlgA1x74wpovomL-El0VXjUPVg_3fpks5t2EFagaJpZM4UCghJ>
.
|
theroozbeh
reviewed
Jun 22, 2018
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <div class="pdatepicker" v-bind:class="{ 'inline' : inlineMode, wrapperClass }"> | |||
| <div class="pdatepicker" :class="inputWrapperClass"> | |||
There was a problem hiding this comment.
There is a much easier and more efficient way to this.
check the next release :)
| @@ -224,6 +224,25 @@ export default { | |||
| return this.endAvailableDateV.year; | |||
| } | |||
| return this.maximumYear; | |||
| }, | |||
|
|
|||
| inputWrapperClass(){ | |||
There was a problem hiding this comment.
by using that method we do not need this function anymore
|
First of all thank you so much for this PR and I'm sorry that I'm replying to you with a long delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set the wrapperClass prop in it was setting the prop itself as the class like : class="wrapperClass"
Fixed ! 👍