Create Imgur onebox

[jzeta]

No description provided.

[coveralls]

Coverage remained the same when pulling 15f5e86 on add-imgur-onebox into 5b8c6a5 on master.

[coveralls]

Coverage remained the same when pulling 0fc9053 on add-imgur-onebox into 5b8c6a5 on master.

[krainboltgreene]

Needs to be able to handle albums.

[coveralls]

Coverage remained the same when pulling 033e09c on add-imgur-onebox into 9be106f on master.

[coveralls]

Coverage remained the same when pulling 9762601 on add-imgur-onebox into 9be106f on master.

[jzeta]

@krainboltgreene I'll create another response for an album. I'll compare with the regular gallery response to determine how the onebox will be able to tell the difference.

[coveralls]

Coverage remained the same when pulling 48fd862 on add-imgur-onebox into 9be106f on master.

[jzeta]

@vykster reminded me that @markijbema's merged but ultimately deleted commit was for imgur onebox 91c6e05

[markijbema]

I understand this is a comment, but please now that ^ and $ don't do what you'd expect in Ruby. You mean (hopefully) \A and \Z.

[krainboltgreene]

We expect them to match the beginning of the line and the end of the line, respectively. That's what they do.

[markijbema]

I have no particular interest in imgur though, mainly did that to play around with the discourse codebase. Did you check you support both albums and images? That's the only interesting part about it (though my fix didn't support that yet, nor did the old code).

I added three comments regarding security concerns. The latter two are about XSS, if you're already in a tag you don't need > or < to inject javascript, so regular sanitation doesn't work. normally.

[jzeta]

Talked to @krainboltgreene, we should create 2 Imgur oneboxes, one for albums and another for galleries. Adding those to #129

[coveralls]

Coverage remained the same when pulling c18dd3f on add-imgur-onebox into 88d5799 on master.

[jzeta]

@vykster and I decided since Discourse only has support for Imgur images, we'll close this PR and add support for albums in v1.2.0. We'll look back at @markijbema's #valid_hash method then. Might consider using JSON parser since that's what Discourse is using, instead of HTML.