Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect custom model implementations in Schemas #97

Open
1 task
theimerj opened this issue Mar 7, 2024 · 0 comments
Open
1 task

Respect custom model implementations in Schemas #97

theimerj opened this issue Mar 7, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@theimerj
Copy link
Contributor

theimerj commented Mar 7, 2024

Problem:

Right now we use Lunar models like so:

// ...

use Lunar\Models\Order;

class OrderSchema extends Schema
{
    /**
     * {@inheritDoc}
     */
    public static string $model = Order::class;
    
    // ...

That means that we do not have direct access to custom model features as well as correct LSP support.

Solution:

  • Try to swap model implementation as described here probably on the Laravel Json API Eloquent repository level?
@theimerj theimerj added the enhancement New feature or request label Mar 7, 2024
@theimerj theimerj added this to the First release milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant