Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Natural disaster list for each wilaya #21

Open
abderrahmaneMustapha opened this issue Sep 29, 2020 · 8 comments
Open

Natural disaster list for each wilaya #21

abderrahmaneMustapha opened this issue Sep 29, 2020 · 8 comments

Comments

@abderrahmaneMustapha
Copy link
Member

add a list of natural disaster for each Wilaya
example :

 {
 "WilayaName": {
    "natural disaster":{
        "earthquakes" : [
             {"name": "name" , "date " :  22-3-2000, "deaths" : 1 , .more ......}
         ],
        "floods": [.......] 
      ........
}
}
}
@Fcmam5
Copy link
Collaborator

Fcmam5 commented Sep 29, 2020

Would you add this to the original dataset or add it as a plugin?
I personally prefer having it as an external dependency, and if I want to use it I'll just install it. Internally that plugin will just merge our data array with this natural disaster by wilaya array. This idea could be the same for each additional information especially those who can be updated consistently (natural disasters, population...)

@abderrahmaneMustapha
Copy link
Member Author

we can schedule a call and talk about it !

@Fcmam5
Copy link
Collaborator

Fcmam5 commented Oct 5, 2020

As a wrap-up for our call:

  • We add an .extend functionality where we extend our library with a new plugin containing a dataset+functions

@Redaloukil
Copy link
Contributor

Redaloukil commented Oct 13, 2020

Yes, @Fcmam5 seems like an excellent idea. I'm really curious to see an implementation of a plugin or extension base on the dateset. and better to move this discussion to algeria api and create a proof of concept of how plugin should be implemented.If everything goes fine, we can mention the plugin in the project as a guide. what do you think ?

@abderrahmaneMustapha
Copy link
Member Author

abderrahmaneMustapha commented Oct 13, 2020

hi @Redaloukil i already start the implementation of this plugin click here

@ZibanPirate
Copy link
Member

@Fcmam5 @Redaloukil @abderrahmaneMustapha we need to work closely with algeria-api-natural-disaster
Will put a draft of the requirements and then As suggested by @Redaloukil we will do a PoC, once tested and proven to be stable, we merge.

Let's keep this thread for highlights and progress, will move the discussion to the slack workspace

@Fcmam5
Copy link
Collaborator

Fcmam5 commented Nov 17, 2020

I'd appreciate scheduling a call to discuss this

@ZibanPirate
Copy link
Member

@Fcmam5 sure thing, @Redaloukil it would be great if you could join an open discussion on slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants