Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

AFNetworking 2.0 support #28

Closed
mirceamironenco opened this issue Mar 18, 2014 · 10 comments
Closed

AFNetworking 2.0 support #28

mirceamironenco opened this issue Mar 18, 2014 · 10 comments

Comments

@mirceamironenco
Copy link

How can i integrate this in a project that is already using AFNetworking 2.0 , one of your classes is using AFHTTPClient which is no longer available in 2.0 ?

@dzenbot
Copy link
Owner

dzenbot commented Mar 18, 2014

I've been thinking about this myself. @ryanfitz already sent a great pull request integrating AFNetworking to 2.0. But some projects still use AFNetworking 1.3.0, and particularly, for those using RestKit (like me), it hasn't yet moved to AFNetworking to 2.0 either.

Would it be a way to support both? 1.3 and 2.0?

@mirceamironenco
Copy link
Author

Honestly i haven't tried it , the migration process from 1.3 to 2.0 is really easy to do , however if your app requires 1.3 there is a problem . My app requires 2.0 and i have a problem with this library, should i try using ryan's pull ?

@dzenbot
Copy link
Owner

dzenbot commented Mar 18, 2014

I'll suggest to give a try to Ryan's pull. The only issue is that you would not be able to install it with pods...
I still want to merge that change someday soon, but 1.3 is still a bit popular. And RestKit hasn't yet upgraded either. Having 2 versions of AFNetworkings with pods, makes no sense.

@mirceamironenco
Copy link
Author

I'll give it a go , thanks . Why don't you make a version available that uses afn 2.0 . Right now you can pod AFN 1.3 and 2.0 , similarly a user could pod DZN 1.0 and let's say 2.0 ( which uses AFN 2.0 ) . Wouldn't this solve the issue?

@dzenbot
Copy link
Owner

dzenbot commented Mar 18, 2014

It's actually a good idea, but the library still need hot fixes to move to 2.0
If I create 2.0 today, it will not benefit of this fixes...isn't it?

@mirceamironenco
Copy link
Author

Theoretically if ryan's pull solves the issue and migrates it to 2.0 , just create 2.0 and update it using that ?

@dzenbot
Copy link
Owner

dzenbot commented Mar 18, 2014

Actually my question was more related to git.
Let's say I create 2.0 with @ryanfitz's pull. When more bugs are fixed on 1.0+, is there a way with git to move those changes to 2.0 and create a new tag with these? If not, 2.0 will only have AFNetworking upgrade but no improvements in other stuff.

@mirceamironenco
Copy link
Author

The changes would only apply to the branch you were
working on . An example of this would actually be afn . Updates
for afn 1.3 and 2.0 are done separetly i believe.

On Tuesday, March 18, 2014, Ignacio Romero Z. notifications@github.com
wrote:

Actually my question was more related to git.
Let's say I create 2.0 with @ryanfitz https://github.com/ryanfitz's
pull. When more bugs are fixed on 1.0+, is there a way with git to move
those changes to 2.0 and create a new tag with these? If not, 2.0 will only
have AFNetworking upgrade but no improvements in other stuff.

Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-37951501
.

@dzenbot
Copy link
Owner

dzenbot commented Mar 18, 2014

That's what I though. I'm going to read a bit more about this and get back to you for a solution.
On the meantime, cloning Ryan's repo might be a quick solution ;)

@dzenbot
Copy link
Owner

dzenbot commented Mar 27, 2014

Closing this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants