Require eieio for jupyter-channel defclass #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping as this bug also came up on the Emacs bug tracker recently https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43969 |
|
I filed https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43969 and can confirm this patch fixed the problem locally. Thanks. |
|
Sorry for being so late on this, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I switched to the Emacs
native-compbranch, and while the missing require apparently didn't really hurt before, after native compiling I got an error that it couldn't find variable jupyter-channel when loading jupyter.This seems to fix it.