Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on a non-existent service "request" #24

Closed
benr77 opened this issue Apr 26, 2020 · 3 comments
Closed

Dependency on a non-existent service "request" #24

benr77 opened this issue Apr 26, 2020 · 3 comments

Comments

@benr77
Copy link
Collaborator

benr77 commented Apr 26, 2020

Installing v4.1 on Symfony 4.4 gives me the following error when I clear the cache:

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:
                                                                                                       
  The service "dz.feature_flags.conditions_bag" has a dependency on a non-existent service "request". 

I can't see where the reference to "request" is coming from. Any ideas?
Thanks

@benr77
Copy link
Collaborator Author

benr77 commented Apr 26, 2020

OK, found it. The service configuration was injecting @request which does not exist. Instead we should be injecting @request_stack.

Submitted PR #25 to fix this - simple tweak to service configuration only, compatible back to Symfony 2.4.

@DZunke
Copy link
Owner

DZunke commented Jun 29, 2020

Thanks @benr77 ... The Pull Request was merged and you'll find the fix in Version 4.2 👍

@DZunke DZunke closed this as completed Jun 29, 2020
@benr77
Copy link
Collaborator Author

benr77 commented Jun 29, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants