Naming of config variables

[mafrosis]

Hey folks, I just added Flask-S3 to a project, and I think the naming of the config variables ought to be changed to be specific to this module; perhaps with a FLASKS3_ prefix (like how the Flask-Security module does it).

I already have a config var called S3_BUCKET in my project, and now I have S3_BUCKET_NAME.. Which doesn't provide the clearest distinction in the code base.

Just a thought. Interested to see what you think.

[bool-dev]

👍

[Fuyukai]

Unfortunately, this would break backwards compatibility, and as most users probably don't pin their dependency versions, it would break their things.

[bool-dev]

@SunDwarf how about throwing deprecation warnings, and falling back to old naming structure if new structure is not used? I'd be happy to spend some time over the weekend and send a pull request.
(I also have some variables in my config starting with S3_ but thankfully no conflicts!)

[mafrosis]

I was thinking of @bool-dev's approach as well (which is how Django handle's this kind of thing). Support both variable names, and show deprecation warnings until the next major release.

[Fuyukai]

I think that's a better idea.

[mafrosis]

@SunDwarf We definitely can't just change the names of the config variables on everyone! ;)