Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR #1

Open
fuyuyuputao opened this issue Aug 12, 2022 · 0 comments
Open

ERROR #1

fuyuyuputao opened this issue Aug 12, 2022 · 0 comments

Comments

@fuyuyuputao
Copy link

fuyuyuputao commented Aug 12, 2022

In made.py, I find an error about building masked matrix. The condition about the last hidden layer to output layer should be ">" not ">=". I think the following codes are more reasonable:

        if i == (len(self.masks) - 1 - 1):
            for j in range(len(m_next)):
                # Use broadcasting to compare m_next[j] to each element in m.
                M[j, :] = torch.from_numpy((m_next[j] > m).astype(int))
        else:
            for j in range(len(m_next)):
                # Use broadcasting to compare m_next[j] to each element in m.
                M[j, :] = torch.from_numpy((m_next[j] >= m).astype(int))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant