Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e-mission-docker clean up #791

Open
aGuttman opened this issue Sep 7, 2022 · 7 comments
Open

e-mission-docker clean up #791

aGuttman opened this issue Sep 7, 2022 · 7 comments

Comments

@aGuttman
Copy link

aGuttman commented Sep 7, 2022

Remove duplicate files from e-mission-docker repo once the docker changes are added to the server repo

@shankari
Copy link
Contributor

Also, change the examples in the e-mission-docker repo to the new server image.

@shankari
Copy link
Contributor

Also, come up with a mechanism to update the tags in the downstream images automatically.

Concretely, if we push a new release to e-mission-server, the webapp and analysis images and the em-public-dashboard repo need to bump up their numbers and rebuild their own images in a cascading set of rebuilds.

Is this supported by GitHub actions? How does cloud services prefer to deal with it?

@shankari
Copy link
Contributor

Try to merge the differences in the internal emissionlhd repo into the public repo so that we don't have to maintain multiple copies. The changes are not very significant - primarily using jq instead of sed which is not a bad fix to have over the longer term.

@shankari
Copy link
Contributor

shankari commented Sep 22, 2022

Per discussion in e-mission/e-mission-server#875 (comment)
decide whether we want to reintroduce a simple static file or stay with the existing redirect

Clean up this if check
https://github.com/e-mission/e-mission-server/pull/875/files#diff-53eb57ac0b49c269c7061b4c454813b0214d14cfbdd45f6950e9367698891eb4R7
if we decide to stay with the redirect

@shankari
Copy link
Contributor

@shankari
Copy link
Contributor

Do we need this given that we only call setup_config while building the image now?
https://github.com/e-mission/e-mission-server/pull/875/files#diff-53eb57ac0b49c269c7061b4c454813b0214d14cfbdd45f6950e9367698891eb4R11

@shankari
Copy link
Contributor

shankari commented Sep 22, 2022

Does this need to be fixed?
Screen Shot 2022-09-22 at 12 22 29 PM

It doesn't seem to be very worrying as long as the containers that run the actions are wiped after every run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants