Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for Admin Dashboard #859

Closed
sebastianbarry opened this issue Feb 20, 2023 · 7 comments
Closed

Testing for Admin Dashboard #859

sebastianbarry opened this issue Feb 20, 2023 · 7 comments

Comments

@sebastianbarry
Copy link
Collaborator

I have started the admin dashboard found at https://github.com/e-mission/op-admin-dashboard/tree/master and it is working!

I had expected to see more of the other changes, such as the Token generation button, view available tokens, etc. but what I got on my computer working looks far more barebones than that, I may be checking out the wrong branch:

Screen Shot 2023-02-20 at 10 15 19 AM

Screen Shot 2023-02-20 at 10 15 30 AM

Screen Shot 2023-02-20 at 10 15 39 AM

Screen Shot 2023-02-20 at 10 16 01 AM

@shankari I see that you are the only person who has made commits to this branch, is @asiripanich branch somewhere?

@asiripanich
Copy link
Member

Hi @sebastianbarry, please see the dev branch. We are in the final stages of implementing the authentication. :)

The code in master is just a Dash dashboard template from NREL visualisation team.

@sebastianbarry
Copy link
Collaborator Author

sebastianbarry commented Feb 22, 2023

Thanks @asiripanich! I have switched to the dev branch but I'm having trouble using docker-compose, it seems to be getting hung up on this point:
image

Additional info:

  • I did delete my Docker images and containers, and re-built and started the containers again and am still getting hung up at this same point.
  • I am also not connected to any VPN or anything.

Have you encountered this before, or have any tips for me?

@sebastianbarry
Copy link
Collaborator Author

I see that this line was added to the dev branch in this commit: e-mission/op-admin-dashboard@054132c#diff-f34da55ca08f1a30591d8b0b3e885bcc678537b2a9a4aadea4f190806b374ddc

This may be why the main branch was working for me but the dev branch is not (using docker-compose method)

@asiripanich
Copy link
Member

I havent tested the latest version of commits. Alireza should be able to guide you to setup the dashboard during our today meeting. :)

@sebastianbarry
Copy link
Collaborator Author

sebastianbarry commented Mar 3, 2023

I was able to get the admin dashboard working and loaded some test user data!

Here are my thoughts while testing

Screenshot of issue Explanation of issue
Screen Shot 2023-03-02 at 4 31 38 PM So far the dashboard looks good. I am not used to being a program admin, so I don't know how helpful or important the diagram of "user sign up count" would be, that requires them to be on the first page dashboard, but I do believe the diagrams look really good and are easy to interact with
Screen Shot 2023-03-02 at 4 43 48 PM I see that the users opcodes are loaded in the above image, that is great! I know that one of the challenges of admins is knowing which User's name/email associates with which OPcode, @shankari would it be against users data privacy if we were to store this information together?
Screen Shot 2023-03-02 at 4 44 25 PM Because a lot of our users are in US, we may want to change this date picker to be in the mm/dd/yyyy format
Screen Shot 2023-03-03 at 10 36 42 AM Occasionally the loading takes a while and I have no feedback that it is loading, is it possible to add some sort of animated loading circles until the page has fully loaded?
Screen Shot 2023-03-03 at 10 39 11 AM Here's another example where a loading animation would be very informative, since without this, the loading on this screen when you click "trips" takes about 8 seconds and without some sort of feedback that it is loading, I would think that the data for "trips" and "UUIDs" would be the same
image What are the requirements that consider a user an "active user". If I were a program admin, I would be alarmed that I have 14 users but none of them are "active?".
Screen Shot 2023-03-03 at 10 47 59 AM This map froze the webpage for about 3 minutes before it loaded and it took a lot of computer power to do so (see the Firefox error I got at the top of the screenshot)

@shankari
Copy link
Contributor

shankari commented Mar 5, 2023

@sebastianbarry

I was able to get the admin dashboard working and loaded some test user data!

how much test user data?

I know that one of the challenges of admins is knowing which User's name/email associates with which OPcode, would it be against users data privacy if we were to store this information together?

correct. we are not allowed to store any PII (name/email etc) on the NREL hosted system per our cyber security rules. Most admins store this separately in an excel file/google doc on their local computer.

Because a lot of our users are in US, we may want to change this date picker to be in the mm/dd/yyyy format

@asiripanich and @AlirezaRa94 are not building this as a custom project for NREL, they are contributing this to the open source community. As such, we should not hardcode any country-specific assumptions unless absolutely essential. For dates/times, I would suggest using a locale-specific display method (e.g. https://docs.python.org/3/library/locale.html)

@shankari
Copy link
Contributor

Closing this since the related issues are being tracked separately in the admin dashboard repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants