Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect bubble position when holding iPad 2 in portrait (vertical) position #13

Open
GoogleCodeExporter opened this issue Mar 20, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link
Collaborator

What steps will reproduce the problem?
1. Hold iPad 2 in portrait position
2. Open Safari
3. Open website (publizar.com)

What is the expected output? What do you see instead?
Bubble should be placed underneath the bookmark icon in Safari. It is currently 
more to the left.

What version of the product are you using? On what operating system?
An iPad 2 with latest OS version

Please provide any additional information below.


Original issue reported on code.google.com by flozano....@gmail.com on 28 Apr 2011 at 1:03

@GoogleCodeExporter
Copy link
Collaborator Author

Good point. We don't account for this at all in the current code. We should fix 
that. :)

Original comment by ntho...@google.com on 8 May 2011 at 9:52

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Collaborator Author

FYI: For an iPad in portrait mode the arrow lines up pretty well if the 
bubbleInner.style.margin is set to '0 0 0 100px'

Original comment by des...@firelit.com on 2 Oct 2011 at 12:05

@GoogleCodeExporter
Copy link
Collaborator Author

Not sure how to issue a pull request on hg but I'ved modified the js file in a 
clone to address this issue:

http://code.google.com/r/robdudley-mobile-bookmark-bubble/source/detail?r=a28380
e2a986f53ec49750f0b303b88986ebb736

Diff attached.

Original comment by rob.dud...@gmail.com on 2 Nov 2011 at 11:56

Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant