Update user data on login

[dasGoogle]

Just another idea that comes from the FSR KeyCloak migration process:

The new FSR Keycloak offers first and last names that we try to keep updated with the actual names of the students. Thus, it might be feasible to update the display names on every login instead of only when creating the user. This would allow students to perform one name change via the KeyCloak for all FSR-related services.

EvaP could still keep its self-service display name override feature so that names that were already changed remain correct.

CC @lukasrad02 @jeriox

[richardebeling]

Sounds good to me. We could do logged updates of first_name_given (and maybe last_name) here:

EvaP/evap/evaluation/auth.py

Lines 154 to 161 in 0c83387

	def update_user(self, user, claims):
	if not user.first_name_given:
	user.first_name_given = claims.get("given_name", "")
	user.save()
	if not user.last_name:
	user.last_name = claims.get("family_name", "")
	user.save()
	return user

If we don't touch first_name_chosen, the name a user set on EvaP would always overwrite any updated values for first_name_given, which I think would be reasonable.

[janno42]

On login, first_name_given and last_name should be updated if the values for a user (identified by the same email) have changed.

A change in email can't be handled by EvaP and a user profile merge must be done manually in this case.

[janno42]

closing. name changes will be handled via the campus management system import instead.

[jeriox]

closing. name changes will be handled via the campus management system import instead.

maybe we should verify if our requirement to have a self-service for the first name in the CMS is actually going to be implemented (cc @SilvanVerhoeven)

[lukasrad02]

maybe we should verify if our requirement to have a self-service for the first name in the CMS is actually going to be implemented

I don't think that this is necessary (nevertheless, it would be nice to have, independent from EvaP), as EvaP already offers a self-service to change the first name. Imports from the CMS should only update first_name_given, but not first_name_chosen, so users that do not have their name set in EvaP will always be shown with the most recent name from the CMS, and for users that have their name set in EvaP, the CMS import does not matter at all.