Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2B-464] JS SDK - Reject promises the correct way #289

Closed
jakubno opened this issue Jan 23, 2024 · 1 comment
Closed

[E2B-464] JS SDK - Reject promises the correct way #289

jakubno opened this issue Jan 23, 2024 · 1 comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code SDK Created by Linear-GitHub Sync

Comments

@jakubno
Copy link
Member

jakubno commented Jan 23, 2024 •
edited

Describe the bug
We're returning string in some places instead of Error.

E2B-464
@jakubno jakubno added bug Something isn't working javascript Pull requests that update Javascript code SDK Created by Linear-GitHub Sync labels Jan 23, 2024
@jakubno jakubno changed the title JS SDK - Reject promises the correct way [E2B-464] JS SDK - Reject promises the correct way Jan 23, 2024
@jakubno
Copy link
Member Author

jakubno commented Jan 23, 2024

Solved by 3d33cba

@jakubno jakubno closed this as completed Jan 23, 2024
@jakubno jakubno added this to the v.27 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working javascript Pull requests that update Javascript code SDK Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakubno