Append to rather than set CXXFLAGS, etc.

[ambrad]

Here:

EKAT/cmake/EkatSetCompilerFlags.cmake

Lines 127 to 133 in 34d2130

	if (CMAKE_Fortran_COMPILER_ID STREQUAL "Intel")
	set (FFLAGS "-warn all -diag-disable=remark -fpscomp logicals")
	set (CXXFLAGS "-Wall -diag-disable=remark")
	else()
	set (FFLAGS -Wall)
	set (CXXFLAGS -Wall)
	endif()

CXXFLAGS is being set rather than string-appended to. This overwrites flags from E3SM's cime_config cmake files.

[ambrad]

Lines of this sort:

EKAT/cmake/EkatSetCompilerFlags.cmake

Line 36 in 34d2130

set(argsMv FLAGS FFLAGS CFLAGS CXXFLAGS LDFLAGS)

are also a problem.

[ambrad]

Never mind; this can't be it. CXXFLAGS is empty on entry to ekat/CMakeLists.txt.

[bartgol]

I think this might be an issue. Macros do not create new scopes, so using a very common name like CXXFLAGS in that macro will alter the value of a potential homonymous var at the call site.

[bartgol]

I confirmed that this is an issue. I put

set (CXXFLAGS "hello world")

at the top of scream's CMakeLists.txt, and printed its value at the bottom, where it showed -Wall instead of hello world. I will fix this right away.