Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vampire and Impostor 2-player endgame can't be won by impostor #247

Open
fariparedes opened this issue May 9, 2024 · 0 comments · May be fixed by #248
Open

Vampire and Impostor 2-player endgame can't be won by impostor #247

fariparedes opened this issue May 9, 2024 · 0 comments · May be fixed by #248

Comments

@fariparedes
Copy link

Because of this line of code:

Town-Of-Us-R/source/Patches/Roles/Vampire.cs

Line 41 in eddc89e

(x.Data.IsImpostor() || x.Is(Faction.NeutralKilling))) == 1)

It's not possible for the impostor to win in a game that's down to the final 2, impostor vs Vampire. If the impostor kills the Vampire, they will lose, despite being the sole surviving killer, because the logic does not check to ensure that a Vampire is still alive in that situation.
@fariparedes fariparedes linked a pull request May 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Vampire endgame fariparedes/Town-Of-Us-F
1 participant
@fariparedes