Out of memory 99 #106
Merged
Out of memory 99 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… memory issues we should only compute for a fraction of the target pointcloud. To compute all neighbors we use a generator.
…lygon's boundaries are not considered within the polygon.
… not overlap. The right and upper boundaries of the tiles should not overlap.
…not have the same order as the base Target pointcloud. For that reason we sequentially partition the target pointcloud.
cwmeijer
requested changes
Mar 29, 2018
There was a problem hiding this comment.
Looks great! Just some formatting things through.
To fix it could you run prospector (see contributing file in root) and have a look at the issues? Fix the whitespace issues with 'autopep8 -i <filename.py>' (don't use -aggressive as it could actually break your code when you do). After that have a look at the now much shorter prospector complaint list and only fix stuff that make sense to you. Not everything is important but unused imports and unused variables should at least be fixed.
|
I have checked the issues with prospector and solved them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To cover issue #99.
From now on compute_neighborhoods is a generator to be memory efficient. This means the user gets an iterator instead of a result. The user needs to call next(compute_neighborhoods) to iterate over the results.