Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockState Filters #3

Closed
SoniEx2 opened this issue Oct 29, 2015 · 2 comments
Closed

BlockState Filters #3

SoniEx2 opened this issue Oct 29, 2015 · 2 comments
Assignees
Milestone

Comments

@SoniEx2
Copy link
Member

SoniEx2 commented Oct 29, 2015

Currently the instrument configuration for blocks can only filter block names. A way to filter based on BlockState (essentially the 1.8 version of the 0-15 block metadata) is needed.

There are 2 formats I can use. Which one should I go with?

Format 1: (This is probably closer to the way Mojang would do it.)

{
    "block": {
        "name": "minecraft:stone",
        "state": {
            "variant": "something"
        }
    },
    "sound": "minecraft:note.pling"
}

Format 2: (This is closer to the way I'm currently doing it. Slightly "flatter" when compared to the above.)

{
    "block": "minecraft:stone",
    "sound": "minecraft:note.pling",
    "state": {
        "variant": "something"
    }
}

Obviously, this is irrelevant when it comes to materials, as, last I checked, different states of the same block can't have different materials.

@skyem123
Copy link

Well, I like Format 2 more.

@SoniEx2 SoniEx2 added this to the 1.0.0 milestone Feb 15, 2016
@SoniEx2 SoniEx2 self-assigned this Feb 15, 2016
@SoniEx2
Copy link
Member Author

SoniEx2 commented Feb 15, 2016

{
  "block": "minecraft:stone",
  "states": [
    {"variant": {"something": "something"}, "sound": {...}},
    {"variant": {}, "sound": {...}}
  ],
  "sound": {...}
}

Without any difference between an empty variant and "sound" outside states list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants