Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i can not reprodu #5

Closed
Dlemand opened this issue Dec 27, 2021 · 3 comments
Closed

i can not reprodu #5

Dlemand opened this issue Dec 27, 2021 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Dlemand
Copy link

Dlemand commented Dec 27, 2021

No description provided.

@Dlemand
Copy link
Author

Dlemand commented Dec 27, 2021

i run this code and use the images of the railway offered by the paper .well, the orbits fits good but the Tower crane in the backround exists some error.e imag
out_00000

@EadCat
Copy link
Owner

EadCat commented Jan 4, 2022

I fixed two lines in the code to obtain local homography as follows:

20220105012835

After that, I tested the code by modifying the following hyperparameters several times.

  1. RANSAC threshold
  2. Random sampling number for RANSAC
  3. gamma (in the paper)
  4. sigma (in the paper)

For example, in a situation where the input image is resized to a size 1000×750, I got this image.

05-thr35-m16-ge5-s8
1 -> 35 / 2 -> 16 / 3-> 0.00005 / 4-> 8, Forced to execute RANSAC 500 times.

As written in the paper, these hyperparameters should be set differently for each size. For example, if you experiment with the same hyperparameters to create an image in a size 2000x1500, you will get the following image.

06-same05-2000x1500

Unfortunately, I've done a few experiments, but I couldn't get a perfect image like the paper with this code.

With the conclusion of the above experiment, hyperparameter setting according to image and size is very important, and I feel that this code needs to be modified so that hyperparameters can be input by option.

I will modify the option ASAP.

Thank you.

@EadCat
Copy link
Owner

EadCat commented Jan 4, 2022

I'm gonna add one more demo using this image!

@EadCat EadCat added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 5, 2022
@EadCat EadCat closed this as completed Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants