Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last next release does not include development builds in dist #1033

Closed
vonagam opened this issue Jun 28, 2023 · 4 comments
Closed

Last next release does not include development builds in dist #1033

vonagam opened this issue Jun 28, 2023 · 4 comments
Assignees
Labels

Comments

@vonagam
Copy link
Contributor

vonagam commented Jun 28, 2023

Can be checked on npm:

Files for current release: 5.0.0-next-20230625
Files for previous one: 5.0.0-dev-ae6b14

In dist/es folder for example and it is visible that last one does not have .development files, while previous one had.

I use vite and it fails due to some problem with resolution of an entry for vest and vest-utils. I assume it is because of this.

Looking back to other versions it is kinda random some do have dev included, some not. There are next and dev tags used in 5.0.0, but seems like both can have development included.

@ealush
Copy link
Owner

ealush commented Jun 29, 2023

Thank you for flagging that. Not sure why it doesn't ship dev build as well. I'll have it fixed today.

@ealush ealush self-assigned this Jun 29, 2023
@ealush ealush added the V5 label Jun 29, 2023
@ealush
Copy link
Owner

ealush commented Jun 29, 2023

Hey @vonagam
I found the issue. I think I fixed it.

Initiated the next release cycle. Will update here

@ealush
Copy link
Owner

ealush commented Jun 29, 2023

Published vest@5.0.0-next-20230629-fc90 Let me know if that one works as expected.

Thank you @vonagam again for flagging this 🙏

@vonagam
Copy link
Contributor Author

vonagam commented Jun 29, 2023

Yep, works without problems. Thanks for fast fix.

@vonagam vonagam closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants