Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[N4S] RULE endsWith #400

Closed
ealush opened this issue Sep 21, 2020 · 2 comments · Fixed by #409
Closed

[N4S] RULE endsWith #400

ealush opened this issue Sep 21, 2020 · 2 comments · Fixed by #409
Labels
good first issue Good for newcomers

Comments

@ealush
Copy link
Owner

ealush commented Sep 21, 2020

Add a new enforce rule:

enforce('hello').endsWith('lo') // ✅
enforce('Hi').endsWith('H') // 🚨
@ealush ealush added the good first issue Good for newcomers label Sep 21, 2020
@omriLugasi
Copy link
Contributor

omriLugasi commented Sep 22, 2020 •
edited

@ealush
The negativeForm of this functionality should be startWith?

@syncush syncush mentioned this issue Sep 22, 2020
Merged
@ealush
Copy link
Owner Author

ealush commented Sep 22, 2020

Heh, no 😅, notEndsWith/doesNotEndWith (maybe both, with an alias, like in greater Than).

startsWith is its own rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(n4s): added endsWith and doesNotEndWith rule syncush/vest
2 participants
@ealush @omriLugasi