-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EASY] Add singular form error selectors #808
Labels
good first issue
Good for newcomers
Comments
Hi 👋🏼 |
@shani-arnon are you still working on this? |
Closed
@jhowlett-scottlogic 👋🏼 |
@shani-arnon Sorry but i do not have the time to work on it now. I had a period of free time but i am now busy again with other commitments |
Hi! Could I work on this? |
Added in V5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add singular form of the following:
getErrors() -> getError()
getWarnings() -> getWarning()
The idea is to return the first error/warning of a field, instead of an array.
Unlike getErrors/getWarnings that can either take 0 or 1 arguments, getError/getWarning must receive a field name.
Function signature:
General guidelines:
Add the functions here:
https://github.com/ealush/vest/blob/latest/packages/vest/src/core/suite/produce/produceSuiteResult.ts#L25-L27
Add to the API reference here:
https://github.com/ealush/vest/blob/latest/website/docs/api_reference.md
Add full documentation here:
https://github.com/ealush/vest/blob/latest/website/docs/writing_your_suite/result_object.md
Also, don't forget about tests.
The text was updated successfully, but these errors were encountered: