Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some discrepancies from the paper #3

Open
ericjang opened this issue Aug 27, 2019 · 2 comments
Open

Some discrepancies from the paper #3

ericjang opened this issue Aug 27, 2019 · 2 comments

Comments

@ericjang
Copy link

For the Mini-ImageNet ResNet-based encoder, I believe the authors use mean pooling instead of max pooling, as done by this implementation. I am currently unable to reproduce the mini-imagenet results with your codebase (even train accuracy does not go up), and am hunting for discrepancies :)

@ericjang ericjang changed the title AvgPool2d instead of MaxPool2d Some discrepancies from the paper Aug 27, 2019
@eambutu
Copy link
Owner

eambutu commented Aug 28, 2019

Awesome thanks so much! I hadn't achieved parity with MiniImagenet yet when I'd stopped working on this, so I appreciate the help! I finally have access to compute resources again, so I might try again this weekend.

One thing that might be worth a shot is trying loading/processing MiniImagenet in a different way: in other meta-learning repos using Miniimagenet, they download the images from the link in (dragen1860/LearningToCompare-Pytorch#4) and do some other normalization (see: https://github.com/dragen1860/MAML-Pytorch/blob/master/MiniImagenet.py#L55).

@suoql
Copy link

suoql commented May 20, 2021

Hey guys, thanks for sharing the suggestions! I added image transformation based on your dataloader. But the train accuracy still cannot go up. Are you guys able to reproduce the results on miniImagenet so far?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants