Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncommitted staged changes after pull #1285

Closed
yaroslavsadin opened this issue Dec 22, 2020 · 9 comments
Closed

Uncommitted staged changes after pull #1285

yaroslavsadin opened this issue Dec 22, 2020 · 9 comments
Assignees
Labels
bug Something isn't working needs-verification Request for community verification
Milestone

Comments

@yaroslavsadin
Copy link

yaroslavsadin commented Dec 22, 2020

  • GitLens Version: v11.0.6
  • Git Version: 2.17.1
  • VSCode Version: 1.52.1
  • OS Version: Ubuntu 18.04

I'm noticing that /usr/bin/git -c core.quotepath=false -c color.ui=false fetch -u origin master:master command is used to Pull changes (hitting repository ↓ button and confirming Pull changes). Problem is, it will update the working tree in a way that I see uncomitted staged changes in the Source control section, as if I reverted all the pulled changes back locally. Simplegit pull as well as Pull command from Source control works fine. Is that the correct git command to pull changes?

@yaroslavsadin yaroslavsadin added potential-bug triage Needs to be looked at labels Dec 22, 2020
@ferreroxc
Copy link

I met the same problem. I have to unstage them all, discard them, check out to another branch, and finally check out back to the first branch. I am editing files on a remote linux machine.

  • GitLens Version: 11.1.0
  • Git version: 2.27.0
  • VSCode Version: 1.52.1
  • OS Version: Mac OS Catalina 10.15.5
  • Git Version on Remote linux machine: 2.27.0

@eamodio
Copy link
Member

eamodio commented Dec 31, 2020

@ferreroxc how are you pulling?

@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. bug Something isn't working and removed triage Needs to be looked at potential-bug labels Dec 31, 2020
@eamodio eamodio self-assigned this Dec 31, 2020
@eamodio eamodio added this to the Soon™ milestone Dec 31, 2020
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition and removed needs-more-info Needs further information, steps, details, etc. labels Jan 2, 2021
@eamodio
Copy link
Member

eamodio commented Jan 2, 2021

Can you please verify this fix in the insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Jan 3, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Jan 3, 2021
@ferreroxc
Copy link

@ferreroxc how are you pulling?

Just as yaroslavsadin described, "hitting repository ↓ button and confirming Pull changes".

@ferreroxc
Copy link

ferreroxc commented Jan 5, 2021

Can you please verify this fix in the insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

When I was trying this insiders edition, I met another problem, which occurred in both the stable and insiders edition.
The remote master was one commit ahead my local master, when I hit the "Refresh" button, the new commit did not show up and everything stayed the same.
refresh_button
I probably should open a new issue to discuss this, but I want to tell you first that I need to try this insiders edition on another computer.

@eamodio
Copy link
Member

eamodio commented Jan 5, 2021

@ferreroxc Hrm, yeah please open a new issue. Although, the refresh button doesn't affect git in any way it just (should) re-render the tree.

@ferreroxc
Copy link

I met the same problem. I have to unstage them all, discard them, check out to another branch, and finally check out back to the first branch. I am editing files on a remote linux machine.

  • GitLens Version: 11.1.0
  • Git version: 2.27.0
  • VSCode Version: 1.52.1
  • OS Version: Mac OS Catalina 10.15.5
  • Git Version on Remote linux machine: 2.27.0

On this machine (let's call it the first Mac), I still face the problem of the broken "Refresh" button, which I open a new issue here. I tried to uninstall -> reinstall Gitlens, reload VScode Window and install VScode Insider, but none helped.

However, when I try on my second Mac, both the "Refresh" button and the "Pull" button work completely fine. Some background info of my second Mac:

  • GitLens Version: Gitlens (Insiders) v2021.1.404
  • Git version: 2.27.0
  • VSCode Version: 1.52.1
  • OS Version: Mac OS Catalina 10.15.6
  • Git Version on Remote linux machine: 2.27.0

Since my first and second Mac share the roughly same OS, VScode, and Git version, I decided to uninstall and reinstall the stable VSCode on my first Mac and see if the problem can be solved.

@ferreroxc
Copy link

I met the same problem. I have to unstage them all, discard them, check out to another branch, and finally check out back to the first branch. I am editing files on a remote linux machine.

  • GitLens Version: 11.1.0
  • Git version: 2.27.0
  • VSCode Version: 1.52.1
  • OS Version: Mac OS Catalina 10.15.5
  • Git Version on Remote linux machine: 2.27.0

On this machine (let's call it the first Mac), I still face the problem of the broken "Refresh" button, which I open a new issue here. I tried to uninstall -> reinstall Gitlens, reload VScode Window and install VScode Insider, but none helped.

However, when I try on my second Mac, both the "Refresh" button and the "Pull" button work completely fine. Some background info of my second Mac:

  • GitLens Version: Gitlens (Insiders) v2021.1.404
  • Git version: 2.27.0
  • VSCode Version: 1.52.1
  • OS Version: Mac OS Catalina 10.15.6
  • Git Version on Remote linux machine: 2.27.0

Since my first and second Mac share the roughly same OS, VScode, and Git version, I decided to uninstall and reinstall the stable VSCode on my first Mac and see if the problem can be solved.

  1. The "Refresh" button is not broken. I misunderstand the real function that the "Refresh" button do, as described here.
  2. The Gitlens (Insiders) v2021.1.404 works completely fine when pulling from a remote branch, so there is no "uncommitted staged changes"

Thank you so much Eric!

@github-actions
Copy link

github-actions bot commented Feb 5, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for community verification
Projects
None yet
Development

No branches or pull requests

3 participants