Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show github auth notification on install? #1352

Closed
Tyriar opened this issue Jan 28, 2021 · 2 comments
Closed

Don't show github auth notification on install? #1352

Tyriar opened this issue Jan 28, 2021 · 2 comments

Comments

@Tyriar
Copy link

Tyriar commented Jan 28, 2021

Just a suggestion to avoid notification fatigue. I got this auth notification on all my machines when I installed gitlens, but we already show the more subtle (1) on the account icon when gitlens requests auth.

Additionally it shows up here:

image

You could also show the auth notification when a user actually tries to use github functionality for the first time, when it's more relevant than extension install.
@Tyriar Tyriar added potential-bug triage Needs to be looked at labels Jan 28, 2021
@eamodio
Copy link
Member

eamodio commented Jan 28, 2021

Duplicate of #1336, #1208

@eamodio eamodio closed this as completed Jan 28, 2021
@eamodio eamodio added duplicate and removed potential-bug triage Needs to be looked at labels Jan 28, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eamodio @Tyriar