Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong initial keyboard focus in interactive rebase #1538

Closed
The-Compiler opened this issue Jun 10, 2021 · 3 comments
Closed

Wrong initial keyboard focus in interactive rebase #1538

The-Compiler opened this issue Jun 10, 2021 · 3 comments
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@The-Compiler
Copy link

  • GitLens Version: 11.4.1
  • Git Version: 2.32.0
  • VSCode Version: 1.56.2
  • OS Version: Archlinux

Steps to Reproduce:

  1. Open an interactive rebase, e.g. via the command palette, "GitLens: Git Rebase...", selecting a branch/commit and interactive rebase.
  2. Press e in an attempt to mark the first commit as "edit"
  3. Notice how the keybindings don't work because the keyboard focus is in some weird place - you'll either need to click the first commit before using the shortcuts; or press the tab key twice.
@The-Compiler The-Compiler added potential-bug triage Needs to be looked at labels Jun 10, 2021
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Jun 12, 2021
@eamodio eamodio self-assigned this Jun 12, 2021
@eamodio eamodio added this to the Soon™ milestone Jun 12, 2021
@eamodio
Copy link
Member

eamodio commented Jun 12, 2021

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Jun 12, 2021
@The-Compiler
Copy link
Author

The-Compiler commented Jun 12, 2021

Thanks for the quick fix! ❤️ I built from sources and can confirm it's working now.

A semi-related question: Given that the bindings for that view seem to be hardcoded, would you consider adding j/k and Shift-J/Shift-K as alternative bindings for Up/Down and Alt-Up/Alt-Down, for people like me who used vim too much and can't go back? 😄 Happy to open a PR if so.

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for community verification labels Jun 14, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Jun 14, 2021
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Jun 14, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

2 participants