Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout arbitrary commit #463

Closed
GandalfSaxe opened this Issue Jul 25, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@GandalfSaxe
Copy link

GandalfSaxe commented Jul 25, 2018

Would you consider to make it a feature to checkout any commit on commit id?

For some inconceivable reason, it's not supported by VSCode itself (unless I missed something). The git checkout command in VSCode only works for branch checkouts when I try.

@eamodio eamodio added this to the Soonish™ milestone Jul 25, 2018

@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Jul 25, 2018

Sounds like a good idea. Thinking it would be another item on the context menu Checkout Commit (via Terminal), along with all the * (via terminal) commands. Does that satisfy your request?

@GandalfSaxe

This comment has been minimized.

Copy link
Author

GandalfSaxe commented Jul 25, 2018

Must ask, the context menu where?
(I just started using your excellent extension a few hours ago).

I was thinking someting along the lines of:
Basically a global command so you can bring up the command pallette, choose "Checkout commit..." and paste in the id/hash of a commit. Context menus also sound good.

@GandalfSaxe

This comment has been minimized.

Copy link
Author

GandalfSaxe commented Jul 26, 2018

The VSCode team confirmed that they see the console command as adequate, and I see their point: Microsoft/vscode#55086 (comment) - though I do think their checkout command would be more flexible if it could take both branch name and commit id.

However I do think it makes sense for git extensions to have this feature in places where you contextually are looking back on previous commits.

@GandalfSaxe

This comment has been minimized.

Copy link
Author

GandalfSaxe commented Jul 26, 2018

I bet this is the context menu you were talking about?

image

If so, then yes it's a good place to add it.

Also in the branch history list view if somehow possible (ctrl+enter or something?):

image

@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Jul 26, 2018

Yeah, that is the menu. And as for the quickpick lists, I'm going to be syncing the commands from the menus and the commands when you select a commit or file.

@eamodio eamodio modified the milestones: Soonish™, Soon™ Jul 29, 2018

@eamodio eamodio self-assigned this Jul 29, 2018

@eamodio eamodio closed this in 910b265 Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.